Bolt datatypes, RowDecodeFailure, routing, Psalm, and result typing#305
Open
p123-stack wants to merge 14 commits into
Open
Bolt datatypes, RowDecodeFailure, routing, Psalm, and result typing#305p123-stack wants to merge 14 commits into
p123-stack wants to merge 14 commits into
Conversation
Collaborator
p123-stack
commented
May 12, 2026
p123-stack
commented
- Bolt hello can expose optional patch_bolt; auth return types should allow it without invalid array offsets.
- Neo4j cluster routing must not call route() on Bolt 4.2 and must pass the correct third argument on 4.3 (?string db) vs 4.4+ (extra map).
- SummarizedResult may internally buffer RowDecodeFailure sentinel rows; callers should see CypherMap/DateTime-style types through current(), get(), toArray(), etc., without @psalm-suppress on the constructor.
- Integration test testDateTime was asserting a single OGM class (DateTimeZoneId) while the server can legitimately round-trip the same instant as Types\DateTime (offset wire form); the test now asserts the supported types and instant equality via toDateTime().
…), PULL n=-1, and Bolt pull/disconnect fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.